Update ReactDOMServerSuspense-test to not use legacy rendering APIs #28251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 952aa74...be76c13 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
rickhanlonii
reviewed
Feb 6, 2024
| @@ -41,7 +41,7 @@ function initModules() { | |||
| }; | |||
| } | |||
|
|
|||
| const {itThrowsWhenRendering, resetModules, serverRender} = | |||
| const {resetModules, itThrowsWhenRendering} = | |||
There was a problem hiding this comment.
@gnoff line 38 is still using ReactDOM instead of ReactDOMClient so the itThrowsWhenRendering tests are still using the legacy renderer.
If you pass ReactDOMClient here:
return {
ReactDOMClient,
ReactDOMServer,
ReactTestUtils,
};Then we switch to hyrdateRoot in the helpers:
There was a problem hiding this comment.
Ah I didn't realize the I had to return the client version for the utils to use it. I took another look and the thing the itThrowsWhenRendering was asserting actually is wrong now for concurrent roots on the client so really the test only should be asserting on server behavior (also probably what the test was written for originally given the filename). I just ripped out the test utils entirely now and it only uses the underlying modules directly.
Thanks for flagging!
gnoff
force-pushed
the
r19-tests-1
branch
2 times, most recently
from
f9e7047 to
f946f51
Compare
Updates ReactDOMServerSuspense-test to not use legacy rendering APIs. Previously this test was relying on suspending in the legacy renderer to throw during server rendering as well as during client rendering. With the advent of concurrent roots on the client however this doesn't make sense and it only makes sense on the server when using legacy apis like renderToString. I have removed the use of ReactDOMServerIntegrationTestUtils in this test suite and limited the tests to server tests using renderToString to keep as much parity with what was being tested before while dropping anything that no longer makes sense to assert on concurrent client roots
gnoff
commented
Feb 6, 2024
Comment on lines
-192
to
-204
| itThrowsWhenRendering( | ||
| 'a suspending component without a Suspense above', | ||
| async render => { | ||
| await render( | ||
| <div> | ||
| <AsyncText text="Children" /> | ||
| </div>, | ||
| 1, | ||
| ); | ||
| }, | ||
| 'A component suspended while responding to synchronous input.', | ||
| ); | ||
| } |
There was a problem hiding this comment.
this is essentially a duplicate of the above test
There was a problem hiding this comment.
I feel like it's worth keeping in case there's something fucky with having a boundary in the tree
rickhanlonii
approved these changes
Feb 6, 2024
huozhi
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 9, 2024
Updates React from 2bc7d336a to ba5e6a832. ### React upstream changes - facebook/react#28283 - facebook/react#28280 - facebook/react#28079 - facebook/react#28233 - facebook/react#28276 - facebook/react#28272 - facebook/react#28265 - facebook/react#28259 - facebook/react#28153 - facebook/react#28246 - facebook/react#28218 - facebook/react#28263 - facebook/react#28257 - facebook/react#28261 - facebook/react#28262 - facebook/react#28260 - facebook/react#28258 - facebook/react#27864 - facebook/react#28254 - facebook/react#28219 - facebook/react#28248 - facebook/react#28216 - facebook/react#28249 - facebook/react#28241 - facebook/react#28243 - facebook/react#28253 - facebook/react#28256 - facebook/react#28236 - facebook/react#28237 - facebook/react#28242 - facebook/react#28251 - facebook/react#28252 Closes NEXT-2411
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
…acebook#28251) Updates ReactDOMServerSuspense-test to not use legacy rendering APIs Also removes an experimental only gate that is not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates ReactDOMServerSuspense-test to not use legacy rendering APIs
Also removes an experimental only gate that is not necessary